| Re: [chrony-dev] Proposal for improvement of memory consumption in chronyd. |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] Proposal for improvement of memory consumption in chronyd.
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Thu, 17 Sep 2020 09:10:27 +0200
- Authentication-results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlichvar@xxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600326638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YNe13rsHAmC4+uonShox9QnZj9p803s8i4ic0aDHwyk=; b=iV0240OeDvxNP2jHutGO1+SEHfrHnGhGlmLDwKdwugss6zkNwti21o/eJ/Bg1FFTEB+0Z+ h4EoVrhItIbL2+3odYJqTau7M6zcKlD2EFG8a33NEiPt2gQED3abRcvQbA61n6Hqdua4mg LKP/uBH9kUbGX0V2TSuDUYaimLtk+SY=
On Wed, Sep 16, 2020 at 11:54:37PM +0200, timekeeper@xxxxxxxxx wrote:
> Dear Chrony community,
>
> We recently start with chrony.eu public ntp pool. As number of clients
> increases we observe in our monitoring platform that aged out clients do not
> free memory.
That's how the client logging was designed. The current code uses
just one large densely-packed table holding all the data. It's not
possible to make holes in it, or move the entries around. The table
can grow (or shrink - but that's not implemented) by a factor of 2.
The hashing would need to be reworked and some garbage collecting
implemented in order to free memory. But I suspect the additional
memory that would be needed for this would outweight any benefits of a
dynamic allocation. The code would be more complex and it would need
more CPU time. Probably not worth the trouble.
My suggestion would be to configure a smaller clientlog limit, so it
covers (on average) only the interval you think is sufficient.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.