| Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Mon, 31 Aug 2020 20:37:38 +1200
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a1-4; h=Feedback-ID:X-Smtpcorp-Track:Message-Id:To:Date: Subject:From:Reply-To:Sender:List-Unsubscribe; bh=3EsbkhBNGE2NO5WcZgZtyIoKVjrrzzdddj9q5kncJlY=; b=N0CBg2yeMyICskvtk16JWq7wvD M65vXFmU6Fy7SFSUG/yWbB+AianWzPEhFFQjy4uJBzWR5SQ0GNEEI6ka3NOnfkud0G+87I1sZaJ9v CWWwlTFFj+7SEIWv60UEzYPq67uSwq/NAXRnfyfGdj+FfpzENEWhRX7gwH9p1LvLwzjW2phBLY8M7 eu42KYj82J138GUDUe2Fbi3NKK7P/J/Hw2ymUWQi3S6jX8H/9HCNDz3La/xSd0FhSP2FvAgbq0IX+ N0Chos6pBZLhFTQGD/c3UfXZBQ1H6taXCk9ppHVjmVnmF4wb2J5QUHBOy9Zp2JIXeV/OuGTwaGo3n tXtKnPCA==;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whatroute.net; i=@whatroute.net; q=dns/txt; s=s149811; t=1598863073; h=from : subject : to : message-id : date; bh=3EsbkhBNGE2NO5WcZgZtyIoKVjrrzzdddj9q5kncJlY=; b=JjT9ok2AlqRMf/7ATcyvb8U9OLEYS+1CqiJvPu/KsON3lbSJjYkPdA6QHmr9Ct8D43LY25 Zt/bEaVPWoHH6hmQZZqaFeEbLPFT54+TnVObe5niM2Y4z9PYLvclsGOytVW9EODL5Li0A80Z PW2KpJVTLWEAPvm/kCwiwMT+qH6VkjYeAFkyyj7JmChSMEOcLjFIcHLLx5Y3fX5uCLjCL+rd /JM+9mGyifS8Q3YhlkqzYjnzz/wwJGhFfErkz3BNiSu27k0uqN/SPTp8OB5su1D6XAJUlIuF MxQ+d6eUl0uxlFeYmPgOrkgP/AmpEtgSLJU0Hxa831Kz2VmY/h4kyurw==
- Feedback-id: 149811m:149811acx33YQ:149811sbYPzVs96N
Hi Miroslav
> On 31/08/2020, at 8:27 PM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> Hopefully Apple will fix this soon. It's interesting they had a
> signed/unsigned bug in both adjtime() and ntp_adjtime().
I submitted a very simple test case to them - it works correctly in 10.15 and fails in 11.0. Whether or not they acknowledge it is a bug remains to be seen, although they were pretty prompt in fixing adjtime() once the error was reported.
In the test, I had run time warnings (from asan and friends) with i << 16 - it didnt like i being a -ve number, so I made the additional tweak of i * (1 << 16)
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.