| Re: [chrony-dev] Handling of leap seconds |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] Handling of leap seconds
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Wed, 25 Mar 2020 08:42:23 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585122153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kdMOB1P0XVzHRunBzBO2x4+/dFUyMws6XznLSz7zHK0=; b=LasUlyaY2KET+qJsqbiPLf0QTSsOZhRXVj00JzBqHqTAptTQLxzsSnKLA0XvSEbWJNs7i3 tpNb3scyzQCYaSvCKS5eVjnmat8SSs8v+5Wf6X9x7rWiqyfBaedq3TOczS25ZyrY1nqy15 LJZJ6bVCQRWluxbdDCqBpz4t+j7mlJM=
On Wed, Mar 25, 2020 at 01:14:29PM +0800, Dennis Law wrote:
> Hello Miroslav,
>
> I have a follow up question regarding this. I found that the
> REF_IsLeapSecondClose() function uses the system time to check if a leap
> second occurrence is close.
> Under the circumstances whereby system time has not yet synchronized,
> wouldn't it be more correct to use timestamp from time sources for this
> check?
The function checks the system time and the NTP time it is tracking.
If the client was started in those 5 seconds around leap and had a
significant offset, it could accept a bad sample, which could cause it
to take longer to synchronize.
I'll extend the check to include the sample time.
Thanks,
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.