| Re: [chrony-dev] [PATCH v2 1/2] test: check if RTC is RTC_UIE_ON capable |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v2 1/2] test: check if RTC is RTC_UIE_ON capable
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Thu, 12 Dec 2019 09:59:05 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576141151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nd75kKonwPCtJMKS5AbNnhDAXhIhmbqCF6xbxVZ40jY=; b=BzHJbBy83McUP8mGepffgBQseW6zw/HpLCUGQ0Qx4mIw0JDP/lIYCDVXxBIL0xiS+FX1Va G9j6OponM9UEYT6VQtAYegHpNaMTnFZwxmQC9Z7dq8eIf2lBGHIzTi9aBcV7YRnBpMPZav qbKIBb4ojvkLVTNK12UoF2R0PRGeTAI=
On Thu, Dec 12, 2019 at 08:39:20AM +0100, Christian Ehrhardt wrote:
> --- a/test/system/101-rtc
> +++ b/test/system/101-rtc
> @@ -4,6 +4,7 @@
>
> check_chronyd_features RTC || test_skip "RTC support disabled"
> [ -c "/dev/rtc" ] || test_skip "missing /dev/rtc"
> +hwclock -r --test | grep -q '^ioctl(.*RTC_UIE_ON, 0):' && test_skip "RTC not RTC_UIE_ON capable"
>
> test_start "real-time clock"
I'd prefer to run the test enabled in this case, but add the chronyd
error to the regexp grepping the log to consider it a success.
The other patch looks good to me.
Thanks,
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.