Re: [chrony-dev] [PATCH v4 2/3] sys: rework initialisation to return a value

[Miroslav Lichvar <mlichvar@xxxxxxxxxx>]

On Wed, Mar 14, 2018 at 03:05:30PM +0100, Christian Ehrhardt wrote:
> This ensures any failure to initialize the clock driver
> will eventually end in a unified clear statement that it failed to do
> so instead of a random mix or EPerm or other issues that happened on
> init.
> 
> The potential root causes (e.g. said Eperm) is still reported as warning.
> 
> Furthermore this allow further patches to plug-in a generic fallback
> mechanism at the level os SYS_Initialise.
> 
> Messages will now look like:
>  CAP_SYS_TIME not present
>  adjtimex(0x8001) failed : Operation not permitted
>  Could not initialise system clock driver

Thanks for explaining it clearly what the motivation is. This patch
and the third patch from the series both look good to me. Let's wait a
bit before reconsidering them for inclusion.

>  void
>  SYS_Initialise(int clock_control)
>  {
> +  int initalised = 0;

Still missing an 'i' here. :)

-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.