Re: [chrony-dev] Patch: avoid infinite select() loop on chronyc

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]


For what its worth, I've also experienced this issue (chronyc spinning on CPU with every select just returning -1), I just hadn't had the chance to dig in and figure out the cause.

On Thu, Nov 30, 2017 at 4:48 PM, Gafton, Cristian <gafton@xxxxxxxxxx> wrote:
When chronyc attempts to chat over the control socket with chronyd, if for whatever reason the first communication attempt fails, chronyc will end up in a permanent loop trying and failing to communicate. This is because in the submit_request() function the select() loop break-exit failsafes are protected by a new_attempt flag which is cleared on the first try and never updated again. The attached patch attampts one way of fixing this..

Thank you,

Cristian





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/