| Re: [chrony-dev] new feature request: add "fast" and "slow" to "clock wrong" and "clock stepped" log messages |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] new feature request: add "fast" and "slow" to "clock wrong" and "clock stepped" log messages
- From: Denny Page <dennypage@xxxxxx>
- Date: Mon, 30 Oct 2017 11:42:14 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1509388938; bh=uCqCooftzSq3SywmKqoInSXuT9YSjMPZb1GPfpmq8J8=; h=From:Content-type:MIME-version:Subject:Date:To:Message-id; b=W4qeFsuV/zZ/tzlrl3BhlzkMuPoWi3yZjn67lZzrCrtgXYatqcOT+izfLopPRetkc /gtPR6ttViNyKmAHX8ClECtBPVaoj6ptnO6zMFU1QKv0UHbkjoy0iy00zIYRwQ5WnM GkRJ5RtKr8VxQbJBjcyqJDZhcuUd8i4EjeXdFT2oWk/vcxSHsGSOsXmkRjNRi+NUUj swQko5ckXWbbaMtFueALb7/EkfcIwNAf1q4le1c84e8DF02HbG7kwCt8dhyr1+RVMv N3xfOGz6fS3o8wyncEp2o0+Bj50xymZ9NdO7IjK44SPzr81UUZbAMqOM6S7qquERzc U0goMVh8hd7Xw==
FWIW, I believe “ahead” and “behind” are the most clear in speaking to the condition before initiating a correct. “Fast” and “Slow” somewhat imply an ongoing condition that may or may not be true. It could be the accuracy of setting the RTC before reboot for instance.
System clock ahead by ?.????????
System clock behind by ?.????????
Denny
> On Oct 30, 2017, at 04:07, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Fri, Oct 27, 2017 at 10:31:16AM -0600, James Feeney wrote:
>> How about, rather than using the term "wrong", instead use the terms "fast" and "slow" to describe this quantity "1.693005 seconds"? Then the log message might read:
>>
>> chronyd[622]: System clock fast by 1.693005 seconds, adjustment started
>>
>> or
>>
>> chronyd[622]: System clock slow by 1.693005 seconds, adjustment started
>
> I agree this would be much clearer for the user. I never remember
> which sign is for fast and slow in what context (it's not consistent
> unfortunately). The trouble is that it would break existing scripts
> that parse the log and the parsing itself would be more difficult if
> it had to look for the word "slow" or "fast" instead of the sign. I'm
> not sure how important that really is.
>
> Do you think it would make sense to keep the sign and indicate whether
> it's fast or slow in parentheses?
>
> System clock wrong by +/-?.??????? (slow/fast) ?
>
> System clock stepped by +/-?.??????? (forward/backward) ?
>
> There are other messages that print an offset, so maybe they could be
> all changed at once to keep it consistent.
>
> What do others think?
>
> --
> Miroslav Lichvar
>
> --
> To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
> For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
> Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.
>
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.