Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]




William G. Unruh __| Canadian Institute for|____ Tel: +1(604)822-3273
Physics&Astronomy _|___ Advanced Research _|____ Fax: +1(604)822-5324
UBC, Vancouver,BC _|_ Program in Cosmology |____ unruh@xxxxxxxxxxxxxx
Canada V6T 1Z1 ____|____ and Gravity ______|_ www.theory.physics.ubc.ca/

On Tue, 11 Jul 2017, Miroslav Lichvar wrote:

On Tue, Jul 11, 2017 at 03:21:42AM +1200, Bryan Christianson wrote:
On 11/07/2017, at 2:49 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
Can you please use Oxford comma? The rest of the documentation is
using it (to the extend I understand it's supposed to be used).

I had never heard of 'Oxford comma' until now :). When I went to school (a long long time ago) we were taught that it is wrong to have a comma before the word 'and' at the end of a list - In fact the Wikipedia entry (https://en.wikipedia.org/wiki/Serial_comma) shows that its use is contested. However, in the interest of consistent style I shall do as you ask.

The problem is that incompetent teachers make up rules, instead of emphasizing
understandability in writing.

Thanks. I didn't know there was such a thing either. :) Couple
releases ago, there was a big update fixing the grammar and style from
Stephen. I personally don't care much which style it is, as long as
it's consistent. When I add new text I try to keep it in British
English, but the differences I'm aware of are mostly just things like
words using s instead of z.

And "our" instead of "or"  colour/color neighbour/neighbor honour/honor.

The Oxford comma is not really a Britsh/American thing. Both countries have
inconsistant styles. In some cases it is really needed.
"She wrote to the pope, her brother and a pedophile"
could be misinterpreted without the comma.


On Tue, Jul 11, 2017 at 11:53:35AM +1200, Bryan Christianson wrote:
I ran the adjtime test on macOS 10.13. The skew results were surprising and appear to me to be the same as what you have on FreeBSD/NetBSD. Quite different from macOS 10.12 and earlier. It looks as though Apple have moved the FreeBSD implementation directly into their kernel (and made a signed/unsigned error at the same time).

That's interesting, but I guess it does make sense.

I think we should stick with calling the netbsd driver from the macOS driver.

I agree, as long as they can fix the adjtime() bug. If it's not fixed,
it would probably be better to disable the fast-slewing feature in
order to avoid adjtime().

--
Miroslav Lichvar

--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.


--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/