| Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime() |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Sat, 1 Jul 2017 00:59:46 +1200
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a1-5; h=Feedback-ID:X-Smtpcorp-Track:Message-Id:To:Date: Subject:From:Reply-To:Sender:List-Unsubscribe; bh=o5BWriKYGxma468Jz+UZ+N3DaR0k7zKr2VZdjpS6vBo=; b=F4H/jkEF8Wl9Gnx5oPXB11/W2J 8pDPAnEucc4pZUiaYzejeElaNFxaM3rtPTBDsI9Rnn163lkkJwLDZIEPk6K6nnk1DMPdebYl4cOJk aZXKtm3qZIjGO9v2agOOU7P4UNpY3VlUMrbotj6r44zhHSsSW9qsHh4zyyJBFp9eZ5A+hbMDqwQBM /0Bzbsj8WRvXUG8aDE/Cyjx1JFCO/DiPixHblnUrKH2GlT90hgsiAfnQ2BgTQ518GdWdAEkv7Ekhv Q0jta2fw92tkaNVZ9fxbXSPzVnJRD17AkylnQp3FOCzcXwsbnfiGhzdO3+EbZUJujlO1sGiFVXBST JssbrCNw==;
- Feedback-id: 149811m:149811acx33YQ:149811s5SKt4R3ei:SMTPCORP
> On 30/06/2017, at 11:37 PM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> This looks great.
Thanks.
>
> Can you please also update documentation of the -r option and the
> dumpdir, corrtimeratio, leapsecmode, rtcsync, maxdrift, and maxslewrate
> directives? Where all supported systems would be listed, it now may be
> better to say everything except macOS before 10.13.
OK - I'll do that.
> Another possibility is to replace this with a new case switch inside
> the Darwin) case which would simply define a macro for versions 10.13
> and newer. SunOS-sun4* used to be some version specific configuration.
Yes - I think this is the cleanest solution. Then there is no need to check for <sys/timex.h>. If it is missing then the tool chain is broken.
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.