| Re: [chrony-dev] [GIT] chrony/chrony.git branch, master, updated. 2.2.1-90-g7cc432f |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [GIT] chrony/chrony.git branch, master, updated. 2.2.1-90-g7cc432f
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Mon, 25 Jan 2016 23:46:47 +1300
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a0-2; h=Feedback-ID:X-Smtpcorp-Track:To:Message-Id:Date: From:Subject; bh=Pj7SH/2v0BcPWJu0atj3e+Y4cm8aC1u5u6qZTCbD+l0=; b=EV30CazMzzCl mL97jJIvoK8nqq7VUJTu2gsfnmetAUW9n+YJKG5CEoAOMYYXQGw0GUlZcODfCvqpD1RgM6jDSng3n UMizDtwqIYC8lW8cxEQvF9o8TEAx0pWBtnARHG1frxYfh1eFz22npBcVRea7UKHXB89rZanGJzmtI 4dFTI6r3gIEIf2Nqz9crTzg0NNoWN+XV8JucKF/RhMs9LG6tl9/d4WHrheuVSyNBov6za+fINTbZ7 g5Fl12nidxv3slaV6lfyoNg8nuZuhcW0noMwFzbe++XPye7sd5bdMMbwdAzcUgrUYDQWc0w6d+at8 2jF2WEaHTYcD73LExUXyHg==;
- Feedback-id: 149811m:149811acx33YQ:149811sj7o7rVqlQ:SMTPCORP
> On 25/01/2016, at 11:36 PM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Sat, Jan 23, 2016 at 08:56:23AM +1300, Bryan Christianson wrote:
>> Many compiler warnings from this patch on OS X
>
>> gcc -O2 -g -Wmissing-prototypes -Wall -pthread -c pktlength.c
>> pktlength.c:58:3: warning: implicit conversion from 'unsigned long' to
>> 'uint16_t' (aka 'unsigned short') changes value from 18446744073709551584
>> to 65504 [-Wconstant-conversion]
>> REQ_LENGTH_ENTRY(online, null), /* ONLINE */
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> pktlength.c:44:5: note: expanded from macro 'REQ_LENGTH_ENTRY'
>> PADDING_LENGTH(data.request_data_field.EOR, data.reply_data_field.EOR) }
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> pktlength.c:40:3: note: expanded from macro 'PADDING_LENGTH'
>> PADDING_LENGTH_(offsetof(CMD_Request, request_data), offsetof(CMD_Reply, reply_data))
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> pktlength.c:37:55: note: expanded from macro 'PADDING_LENGTH_'
>> ((request_length) < (reply_length) ? (reply_length) - (request_length) : 0)
>
> Hm, the result is the third operand for this case, so I'm not sure why it
> complains about overflow in the conversion of the second operand.
>
> Can you please try it with this patch?
>
That fixes it thanks. No warnings at all.
B
—-
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.