Re: [chrony-dev] GCC issue

[Miroslav Lichvar <mlichvar@xxxxxxxxxx>]

On Tue, Jan 21, 2014 at 04:09:33PM -0800, Bill Unruh wrote:
> On Tue, 21 Jan 2014, Dale R. Worley wrote:
> >fclose() returns 0 on success and EOF on failure, and it's generally
> >not a good idea to use "|" on values whose bit-pattern you do not
> >understand.
> 
> But with the bitwise or, if ANY bit is non zero, the result is nonzero, which
> is what you want. So in this case it is fine. No matter what fclose returns,
> unless it is zero it is an error.

This is the commit that was pushed to git:

http://git.tuxfamily.org/chrony/chrony.git/?p=chrony/chrony.git;a=commitdiff;h=925d7119ec0db3620a2350eca3cbaea1a8eb4306

If you see any problems with it, please let me know.

-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.