| Re: [chrony-dev] Patch for chown warnings. |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
On Sat, Dec 19, 2009 at 10:20:50PM -0800, Bill Unruh wrote:
> Here is a suggestion re the chown warning-- the program can only chown if the
> user is root so there is no point in trying if not.
Even without root privileges the process can change group ownership to
any group which the chrony user is a member. I doubt this will be ever
used with chrony, but I don't see a reason why it should be
disallowed.
> If the old user of those
> old drift files no longer exists, then the chown will not work. Not sure if
> this should be in WARN or INFO. log
WARN is probably better to be consistent with the other LOG calls in
the functions.
I've pushed the patch (without the geteuid checks). Thanks.
--
Miroslav Lichvar
---
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.