[vhffs-dev] [1991] renamed Vhffs::Object::get_user() to get_owner(), because get_user is confusing, especially on group objects

[ Thread Index | Date Index | More vhffs.org/vhffs-dev Archives ]


Revision: 1991
Author:   gradator
Date:     2012-02-02 23:07:24 +0100 (Thu, 02 Feb 2012)
Log Message:
-----------
renamed Vhffs::Object::get_user() to get_owner(), because get_user is confusing, especially on group objects

Modified Paths:
--------------
    trunk/vhffs-api/src/Vhffs/Object.pm
    trunk/vhffs-irc/modobot.pl
    trunk/vhffs-robots/src/cvs_public.pl
    trunk/vhffs-tools/src/vhffs-managemail
    trunk/vhffs-tools/src/vhffs-moderate

Modified: trunk/vhffs-api/src/Vhffs/Object.pm
===================================================================
--- trunk/vhffs-api/src/Vhffs/Object.pm	2012-02-02 21:45:55 UTC (rev 1990)
+++ trunk/vhffs-api/src/Vhffs/Object.pm	2012-02-02 22:07:24 UTC (rev 1991)
@@ -409,7 +409,7 @@
 	my $comments = shift;
 
 	my $vhffs = $self->{main};
-	my $user = $self->get_user;
+	my $user = $self->get_owner;
 
 	$self->set_status( Vhffs::Constants::WAITING_FOR_CREATION );
 	$self->set_refuse_reason( '' );
@@ -472,7 +472,7 @@
 	my $reason = shift;
 
 	my $vhffs = $self->{main};
-	my $user = $self->get_user;
+	my $user = $self->get_owner;
 
 	$self->set_status( Vhffs::Constants::VALIDATION_REFUSED );
 	$self->set_refuse_reason( $reason );
@@ -521,7 +521,7 @@
 	my $self = shift;
 
 	my $vhffs = $self->{main};
-	my $user = $self->get_user;
+	my $user = $self->get_owner;
 
 	# TODO: write a beautiful module for INTL
 	bindtextdomain('vhffs', '%localedir%');
@@ -653,7 +653,7 @@
 }
 
 
-sub get_user
+sub get_owner
 {
     my $self = shift;
     if( defined $self->{'user'} )
@@ -831,7 +831,7 @@
 
 Returns the Vhffs::Group instance that own this object. Returns undef is fails.
 
-=head2 get_user( )
+=head2 get_owner( )
 
 Returns the Vhffs::User instance that own this object. Returns undef is fails.
 

Modified: trunk/vhffs-irc/modobot.pl
===================================================================
--- trunk/vhffs-irc/modobot.pl	2012-02-02 21:45:55 UTC (rev 1990)
+++ trunk/vhffs-irc/modobot.pl	2012-02-02 22:07:24 UTC (rev 1991)
@@ -78,7 +78,7 @@
 		foreach my $obj ( @{$objects} ) {
 			next if( $seq && exists( $oldobjects{$obj->get_oid} ) );
 
-			my $user = $obj->get_user;
+			my $user = $obj->get_owner;
 			my $group = $obj->get_group;
 			my $object = Vhffs::ObjectFactory::fetch_object( $vhffs , $obj->{object_id} );
 			my $duration = delay_modo($obj->get_date);
@@ -374,7 +374,7 @@
 	}
 
 	my $users = Vhffs::Group::get_users( $group );
-	my $owner = $group->get_user->get_uid;
+	my $owner = $group->get_owner->get_uid;
 	my $list = '';
 	foreach ( @{$users} ) {
 		$list .= '@' if $_->get_uid == $owner;

Modified: trunk/vhffs-robots/src/cvs_public.pl
===================================================================
--- trunk/vhffs-robots/src/cvs_public.pl	2012-02-02 21:45:55 UTC (rev 1990)
+++ trunk/vhffs-robots/src/cvs_public.pl	2012-02-02 22:07:24 UTC (rev 1991)
@@ -72,7 +72,7 @@
 
 		# fix passwd file
 		open( FILE , '>'.$passwd_file ) or die( 'cannot open '.$passwd_file );
-		print FILE 'anonymous::'.$cvs->get_user->get_username."\n";
+		print FILE 'anonymous::'.$cvs->get_owner->get_username."\n";
 		close( FILE );
 		chown $cvs->get_owner_uid , $cvs->get_owner_gid , $passwd_file;
 	}

Modified: trunk/vhffs-tools/src/vhffs-managemail
===================================================================
--- trunk/vhffs-tools/src/vhffs-managemail	2012-02-02 21:45:55 UTC (rev 1990)
+++ trunk/vhffs-tools/src/vhffs-managemail	2012-02-02 22:07:24 UTC (rev 1991)
@@ -640,7 +640,7 @@
 		return;
 	}
 
-	my $ml = Vhffs::Services::MailingList::create( $vhffs, $local_part, $domain->get_domain, '', $domain->get_user, $domain->get_group );
+	my $ml = Vhffs::Services::MailingList::create( $vhffs, $local_part, $domain->get_domain, '', $domain->get_owner, $domain->get_group );
 	unless(defined $ml) {
 		$ui->error('Unable to create mailing list');
 		return;

Modified: trunk/vhffs-tools/src/vhffs-moderate
===================================================================
--- trunk/vhffs-tools/src/vhffs-moderate	2012-02-02 21:45:55 UTC (rev 1990)
+++ trunk/vhffs-tools/src/vhffs-moderate	2012-02-02 22:07:24 UTC (rev 1991)
@@ -24,7 +24,7 @@
 	}
 	else {
 		foreach ( @{$objects} ) {
-			my $user = $_->get_user;
+			my $user = $_->get_owner;
 			my $group = $_->get_group;
 			my $object = Vhffs::ObjectFactory::fetch_object( $vhffs , $_->{object_id} );
 


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/