Re: [eigen] Specializing max_coeff_visitor for some number types

[Christoph Hertzberg <chtz@xxxxxxxxxxxxxxxxxxxxxxxx>]

On 19.08.2014 15:53, Christoph Hertzberg wrote:
> On 17.08.2014 19:34, Marc Glisse wrote:
> > Any comment on this patch?
> > http://listengine.tuxfamily.org/lists.tuxfamily.org/eigen/2014/06/msg00012.html
>
> Hi Marc,
>
> sorry I forgot about this thread, so thanks for the reminder.
>
> As no further objections arose to your patch, I'll commit it soon.

One thing that is missing is that only LU decompositions are considered 
by your patch.
Actually, a clean solution should somehow share the pivoting code for 
all pivoting decompositions. At least for QR and LU the code is very 
similar at the moment. Any thoughts?

Christoph


> I think adding some documentation somewhere here would be nice:
> http://eigen.tuxfamily.org/dox-devel/TopicCustomizingEigen.html#CustomScalarType
>
>
> Christoph
>
>
> > On Sun, 22 Jun 2014, Marc Glisse wrote:
> >
> > > Hello,
> > >
> > > here is a new version of the patch.
> > >
> > > I could have made abs_knowing_score safe against users specializing
> > > scalar_score_coeff_op as a derived class of a default
> > > scalar_score_coeff_op for a different type, but I don't think it is
> > > necessary. Also, I don't really know where to put abs_knowing_score,
> > > it is not a unary functor, but moving it far from
> > > scalar_score_coeff_op seems strange. And should it appear in the doc?
> > > For now I made it so it doesn't. I rely on the compiler eliminating
> > > dead code for abs_knowing_score, making the access to the coefficient
> > > lazy is more complicated and, I think, unnecessary.


--
----------------------------------------------
Dipl.-Inf., Dipl.-Math. Christoph Hertzberg
Cartesium 0.049
Universität Bremen
Enrique-Schmidt-Straße 5
28359 Bremen

Tel: +49 (421) 218-64252
----------------------------------------------