| Re: [eigen] NEON remaining failing tests |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] NEON remaining failing tests
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 4 Mar 2010 09:02:45 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=DiBmw9jdUe21f0hn+kJlr/Tsac4sz07FcuojPbrxf1E=; b=XwbeZqWXRcfSJkbbh7OhWZfzTcL+qHwJY04pmDst4kHwzcBAsumb6iCu47YOFgaUPT Dn6Qgb/8ntytM4LR4YmMCHKOGtuuPbmfrrTo3VUs513LmW1Zd7VKKmlDespGeWf1HoRw Nz8156aVuSoytD2lTRbtEs7yDLgudRGScHs5o=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=ZMW2GgSpdz82E74dUf9efFMAb8OdTTuA6IZyMFbMCQryrmaWDhmHRmFPvx3WOioJpI TE1jxAkIl05CTcEvOfIf2YF7cayDKQFmtkrrJXf2J1+yZRwXIMXcsjvy1xz1/oxsSMhC pi+5ub5/pF1SG18lWQhJ2ICrEs8Vv4tyU8l7g=
2010/3/4 Konstantinos Margaritis <markos@xxxxxxxx>:
> On Thursday 04 March 2010 15:43:21 Benoit Jacob wrote:
>> Hi,
>>
>> Some comments on some of these.
>>
>> if some platforms can't vectorize integer division, we should provide
>> a way for them to say it and use a scalar path.
>>
>> It's pretty simple actually. integer division is going to be
>> implemented somewhere as a functor in Functors.h. It's probably called
>> ei_scalar_div_op or ei_scalar_quotient_op... there, at the place where
>> we say that it has packet access, you just have to add a #ifndef
>> ARM_NEON... same for AltiVec by the way.
>
> and SSE, right now no SIMD engine provides a way to do integer division.
OK, fixed. For reference:
diff -r 8a8f4e9e04bf -r 290fe15bd653 Eigen/src/Core/Functors.h
--- a/Eigen/src/Core/Functors.h Wed Mar 03 12:15:34 2010 -0600
+++ b/Eigen/src/Core/Functors.h Thu Mar 04 09:03:06 2010 -0500
@@ -179,7 +179,7 @@
enum {
Cost = 2 * NumTraits<Scalar>::MulCost,
PacketAccess = ei_packet_traits<Scalar>::size>1
- #if (defined EIGEN_VECTORIZE_SSE)
+ #if (defined EIGEN_VECTORIZE)
&& NumTraits<Scalar>::HasFloatingPoint
#endif
Benoit